Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to let the portals keep running in background. #1328

Closed
wants to merge 4 commits into from

Conversation

axlan
Copy link

@axlan axlan commented Dec 26, 2021

This is a really simple mod I made to support using this project both for it's Wifi management, and also as a general configuration page. To do this I run the class in non-blocking mode, and I want the config portal to keep running even after the WiFi connection completes successfully. I also made the corresponding issue: #1327 .

@axlan
Copy link
Author

axlan commented Dec 28, 2021

I added some additional commits I needed to support my particular use case ( https://github.com/axlan/extended-wifimanager ) . You may not want the parts that change the portal shutdown behavior, but I found using a std::unique_ptr for the WiFiManagerParameter memory management, made the interface a lot less error prone (I was hitting bugs when my vector of parameters would do move constructors).

@axlan axlan closed this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant