-
-
Notifications
You must be signed in to change notification settings - Fork 12
Change some of the more incorrectly (?) named emojis #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In general, I'd say that modifiers are currently used both way too extensively, and not extensively enough. |
This requires multi-character symbols because of the envelope emoji. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General notes:
- You make frequent references to what emoji look like, but afaict this isn't actually standardized anywhere and entirely dependent on the font being used. Ideally, we should stick to what Unicode actually says.
- When, how and by whom was it decided that we would be using US english as a standard?
@@ -106,7 +106,7 @@ bike 🚲 | |||
.not 🚳 | |||
bikini 👙 | |||
billiards 🎱 | |||
bin 🗑 | |||
wastebasket 🗑 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems kind of long, even tho it's the official Unicode name. I would suggest something like trashbin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of points to make here. First, trash bin is a broader term than waste basket, which largely has the connotation of a receptacle for paper waste (think office). Second, bin is not commonly used in american english. We could use trash can instead, but that still has the first problem.
No, there is no formal standardization, but major implementations have essentially converged on a common general look. This is important for e.g. interoperability reasons. See https://www.unicode.org/reports/tr51/#Design_Guidelines "While the shape of the character can vary significantly, designers should maintain the same “core” shape, based on the shapes used mostly commonly in industry practice" As an example, see the entry for the card index emoji https://emojipedia.org/card-index#designs
Just look at the language used in the rest of typst. It's clearly the US english spelling that is used. For instance "color" , "gray" and "transparentize", and not "colour", "grey" and "transparentise" I don't particularly care which standard is used, but it should be consistently applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments but did not think about everything into too much details.
Co-authored-by: Malo <57839069+MDLC01@users.noreply.github.com>
Co-authored-by: Malo <57839069+MDLC01@users.noreply.github.com>
Co-authored-by: Malo <57839069+MDLC01@users.noreply.github.com>
@laurmaedje this contains breaking changes |
Wouldn't be possible to merge it yet anyway due to the multi character symbol |
Current emoji naming is very inconsistent, and in some cases wrong. I initially started taking notes for every single emoji, but that turned out to simply be too much. This is a more constrained PR renaming some of the more clear cut cases as a start
We probably need some deprecation warnings if we want to proceed here, but I wanted to get feedback before adding them.
aesculapius -> asclepius: The former is the latin name. A more radical naming would be "medical"
aubergine -> eggplant: This is the name in US english
basecap -> cap: The former seems to be an example of https://en.wikipedia.org/wiki/Pseudo-anglicism . We could use "baseballcap" or "cap.baseball", but I don't think there are other cap emojis.
beetle.lady -> ladybug: This is the name in US english
bin -> wastebasket: Bin is rarely used in US english
camel.dromedar -> camel.dromedary: This was either a typo, or the German name.
cardindex -> rolodex: More common name, and it's literally what the emoji is depicting
cassette -> vhs: Cassette is more commonly used for audio cassettes, while the emoji depicts a video cassette (vhs).
clip -> paperclip: I'm not aware that the short form "clip" is used for this.
clips -> paperclip.linked: See above. An alternative is "paperclips", but the emoji does specifically depict linked paperclips.
crystal -> crystalball: I honestly think this might have just been an oversight?
cutlery -> silverware: Again, this is the most common terminology in US english
dino.pod -> dino.sauropod: The original name was strange. Alternatively "dino.saur" or just "dinosaur" or "sauropod"
dino.rex -> dino.trex: Alternatively just "trex"
feeding.breast -> breastfeeding
fuelpump -> gaspump: Common name in US english. Fuel pump can also mean other things.
helix -> dna: The emoji specifically depicts the DNA double helix.
moyai -> moai: typo?
partalteration -> partalternation: typo (as an aside, this seems very obscure)
railway -> railroad: US english
ringbuoy -> lifebuoy: US english
satdish -> satellite.dish
shoe.thong -> shoe.flipflop: US english
tm -> trademark: Alignment with symbols.txt
reg -> trademark.registered: Alignment with symbols.txt
envelope: This emoji was missing
tray.mail -> envelope.incoming: This seems to have been misplaced under tray.
unknown: Removed, since this was the "white hair" emoji component, and not an actual emoji.