Skip to content

Add domino tiles #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add domino tiles #75

wants to merge 1 commit into from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented May 24, 2025

A submodule turned out to be super useful here, because it made it possible to have order-dependent modifiers

@T0mstone
Copy link
Collaborator

There's a bit of a bikeshed here about whether the plain n domino should be n.zero or n.n.

@Enivex
Copy link
Collaborator Author

Enivex commented May 24, 2025

There's a bit of a bikeshed here about whether the plain n domino should be n.zero or n.n.

I'm not sure I understand what you mean. Could you elaborate?

@MDLC01
Copy link
Collaborator

MDLC01 commented May 24, 2025

I think this is about the default variant for each domino symbol n, which I agree we may want to switch to n.n.h instead of n.zero.h

@Enivex
Copy link
Collaborator Author

Enivex commented May 24, 2025

I'm not well versed in dominoes, but it seems more natural to me that "five" refers to "five and nothing" instead of "five and five". The current order is also convenient because it's sorted.

@Enivex
Copy link
Collaborator Author

Enivex commented May 24, 2025

Did you mean something like this then?

five
    .five.h 🁙
    .five.v 🂋
    .zero.h 🁔
    .zero.v 🂆
    .one.h 🁕
    .one.v 🂇
    .two.h 🁖
    .two.v 🂈
    .three.h 🁗
    .three.v 🂉
    .four.h 🁘
    .four.v 🂊
    .six.h 🁚
    .six.v 🂌

I'm not a fan, but I guess I'll defer to someone who actually knows anything about dominoes.

My understanding is that a domino with two fives on it would be referred to as a "double"

(There's also the question of whether the exact fallback is even important.)

@Enivex Enivex added the waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants