Add ability to specify chart generation url for self hosted QuickChart #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhumborl
reviewed
Mar 11, 2022
if user specify: a host only, default to https:443, a host and http, set port to 80 a host and https, set port to 443
Owner
|
Thank you! |
Contributor
Author
|
Could you please deploy a new version of the nuget package, including this work? Thanks |
Owner
|
Released in 2.3.0 :) |
Contributor
Author
|
Thank you !
From: Ian Webster ***@***.***>
Sent: 15 March 2022 06:23
To: typpo/quickchart-csharp ***@***.***>
Cc: Diana Duca ***@***.***>; Author ***@***.***>
Subject: Re: [typpo/quickchart-csharp] Add ability to specify chart generation url for self hosted QuickChart (PR #5)
Released in 2.3.0 :)
—
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWNRJF474CXGMJJZYFRW4CLVAAUE5ANCNFSM5QQF3BIA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
…________________________________
***** E-mail confidentiality notice *****
[Law Business Research]<https://lbresearch.com/>
Law Business Research<https://lbresearch.com> is the trading name of Law Business Research Ltd and its subsidiaries.
This message is intended for the addressee only. It is private and confidential. If you have received this message in error, please notify ***@***.*** and remove it from your system.
Law Business Research Ltd. Registered company in England & Wales. No. 03281866. Registered Office address: Meridian House, 34-35 Farringdon Street, London, EC4A 4HL
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.