-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rwlock typings #332
Added rwlock typings #332
Conversation
https://github.com/71104/rwlock/blob/master/package.json#L18 |
Pure styling: since it is namespaced in |
Even if the import is with |
The general convention would be following what's in the @blakeembrey, I asked about this a while ago: This case is clear:
Would like to confirm on this:
|
I'll also rename the file then 👍 |
I think you don't have to. You can change that in the future if needed. Will not do any harm since it is the main. |
Committed the changes 👍 |
FWIW, you won't be able to access @unional Let's stay true to the source. If anything, that's the source of truth and there needs to be no extra questions. |
|
So meaning save it as lib/a.d.ts. 😄 |
Filling in these fields will make it easier for us to review:
Typings URL: [E.g. https://github.com/CaselIT/typings-rwlock]
Source URL: [E.g. https://github.com/71104/rwlock]
Thanks for contributing!