fix yarn when running inside winpty

[jetersen]

see yarnpkg/yarn#2998 (comment)

fixes #627
fixes #635

[jetersen]

This issue won't exist in https://github.com/yarnpkg/berry

This is only related to yarn v1

[jetersen]

Not sure if we should add some sort of conditional logic to the getScript's render function based on version of yarn.

I also question the need for specifically running with yarn. Perhaps the better suggestion is to assume npx?

[arcanis]

I also question the need for specifically running with yarn.

No, you must use yarn run if the packages are installed with Yarn. Npx has no idea about the mechanisms we use to layout the files, which are bound to differ.

Not sure if we should add some sort of conditional logic to the getScript's render function based on version of yarn.

At the very least I think you should add a check for Yarn 1 vs Yarn 2 (but only when winpty is an available command), as --no-interactive isn't a valid option in Yarn 2 (and it doesn't silently accept invalid options anymore).

[jetersen]

As I suspected @arcanis :)

[jetersen]

Since yarn v2 is the only one with pnp?

would it make sense for yarn v1 to use npx?
or do you want us to do the winpty dance?

[arcanis]

I wouldn't recommend using npx for Yarn. I don't control this package and I can't ensure that it'll stay compatible with us. For all we know maybe npm will one day want to make their own install processes that will be incompatible with node_modules. It also looks fairly unmaintained so ... 🤷‍♀️

[jetersen]

I reverted lots of the changes and made it use a simpler approch