Sound or unsound treatment of collection Object parameters; fixes #3040 #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters-may-be-null-not-enabled into collection-object-parameters-may-be-null
…arameters-may-be-null
…arameters-may-be-null
…eters-may-be-null
…eters-may-be-null
…:mernst/checker-framework into collection-object-parameters-may-be-null
…eters-may-be-null
…eters-may-be-null
cpovirk
reviewed
Mar 25, 2020
cpovirk
reviewed
Mar 25, 2020
checker/jdk/nullness/src/java/util/concurrent/BlockingDeque.java
Outdated
Show resolved
Hide resolved
checker/jdk/nullness/src/java/util/concurrent/ConcurrentSkipListSet.java
Outdated
Show resolved
Hide resolved
cpovirk
reviewed
Mar 25, 2020
...in/java/org/checkerframework/checker/nullness/collection-object-parameters-may-be-null.astub
Outdated
Show resolved
Hide resolved
...in/java/org/checkerframework/checker/nullness/collection-object-parameters-may-be-null.astub
Show resolved
Hide resolved
…eters-may-be-null
cpovirk
approved these changes
Mar 26, 2020
wmdietl
approved these changes
Mar 27, 2020
changelog.txt
Outdated
| -AuseDefaultsForUncheckedCode to -AuseConservativeDefaultsForUncheckedCode | ||
| The old name works temporarily but will be removed in a future release. | ||
|
|
||
| For collection methods with `Object` formal parameter type, such as contains, |
There was a problem hiding this comment.
Maybe add Nullness Checker: or something, to make it clear which checkers are affected by this.
| */ | ||
| @Pure | ||
| public int indexOf(@Nullable Object o) { | ||
| public int indexOf(@NonNull Object o) { |
There was a problem hiding this comment.
It's a bit odd that the @NonNull is made explicit here (and before in the wildcard bounds).
NonNull is the default here and not used for non-Object parameter types.
Do you want these explicit? If so, maybe add a note in the README about this convention?
There was a problem hiding this comment.
Note that you didn't make NonNull explicit in AbstractMap below...
| import java.util.Map; | ||
| import org.checkerframework.checker.initialization.qual.*; | ||
| import org.checkerframework.checker.nullness.qual.*; | ||
| import org.checkerframework.checker.regex.qual.*; |
There was a problem hiding this comment.
Why import all these annotations, even though they aren't used?
Why not import @Pure, which is used?
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| System.out.println(line); | ||
| try (InputStream in = getClass().getResourceAsStream("/git.properties")) { |
There was a problem hiding this comment.
Not clear how this is related to this PR?
cpovirk
added a commit
to cpovirk/typetoolsjdk
that referenced
this pull request
Aug 3, 2020
Parts of this are relevant to typetools/checker-framework#3197 Other parts are a followup to typetools/checker-framework#3063 Merge with typetools/checker-framework#3549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together with typetools/jdk#34 and plume-lib/plume-util#50