Use Nullness checker to annotate KeyStore.java.

[xingweitian]

Related PR:

• Fork xingweitian, branch nullness-java-security-keystore annotated-libraries#38
• Use Nullness checker to annotate KeyStore.java. jdk#20

[mernst]

Please make the same edits in the Java 11 annotated JDK, in repository https://github.com/typetools/jdk. Then, we will merge the two pull requests together.

Thanks!

[xingweitian]

@mernst I have already changed to the correct jdkShaHash and travis has been passed.

Here is my pull request on typetools/jdk: typetools/jdk#20
And the corresponding jdk8 pull request: typetools/annotated-libraries#38

[mernst]

Thanks for the annotations.

There were problems with this pull request and the associated pull request typetools/jdk#20.

• @Nullable char [] varname is a declaration of an array of @Nullable char, which makes no sense because char is primitive. I think you meant char @Nullable [] varname, which declares a nullable array of char.
• There were missing annotations, which I discovered by grepping for "null" in the documentation. When annotating a file, it is important to annotate the whole thing, not just a few methods. Otherwise, it is very confusing for people later to use a partially-annotated file or to debug why the annotations are not consistently present.
• You did not add @AnnotatedFor annotations to the classes.

Please see the changes that I made to both pull requests. In future pull requests, could you address those items?

I think this is ready to be merged now (though you also assigned @wmdietl). Thanks again.

[xingweitian]

Thanks for the annotations.

There were problems with this pull request and the associated pull request typetools/jdk#20.

• @Nullable char [] varname is a declaration of an array of @Nullable char, which makes no sense because char is primitive. I think you meant char @Nullable [] varname, which declares a nullable array of char.
• There were missing annotations, which I discovered by grepping for "null" in the documentation. When annotating a file, it is important to annotate the whole thing, not just a few methods. Otherwise, it is very confusing for people later to use a partially-annotated file or to debug why the annotations are not consistently present.
• You did not add @AnnotatedFor annotations to the classes.

Please see the changes that I made to both pull requests. In future pull requests, could you address those items?

I think this is ready to be merged now (though you also assigned @wmdietl). Thanks again.

Thanks a lot for the helpful advice! Sorry for the missed and wrong usage of annotations, I will do better in the next time.

[wmdietl]

@xingweitian Thanks for the specifications and @mernst thanks for the review!