Skip to content

Make the Gradle-version CI matrix use the requested Gradle version - #30

Open
mernst wants to merge 1 commit into
mainfrom
config-cache-1
Open

Make the Gradle-version CI matrix use the requested Gradle version#30
mernst wants to merge 1 commit into
mainfrom
config-cache-1

Conversation

@mernst

@mernst mernst commented Aug 8, 2026

Copy link
Copy Markdown
Member

The test-gradle job passes -Ptest.gradle-version but no test.java-toolchain, and build.gradle.kts forwarded the Gradle version to the test JVM only when the toolchain property was also set. Every matrix job therefore ran against the Gradle version embedded in the build.

Forwarding the property reveals that Gradle below 8.2.1 cannot configure a Kotlin DSL build script that applies this plugin, because the plugin is compiled by the Kotlin compiler embedded in a newer Gradle. Skip the Kotlin DSL tests there; the Groovy tests still cover those Gradle versions.

Also refresh the version matrix and fix the test-report artifact path, which named a source set that does not exist.

The test-gradle job passes -Ptest.gradle-version but no test.java-toolchain,
and build.gradle.kts forwarded the Gradle version to the test JVM only when
the toolchain property was also set.  Every matrix job therefore ran against
the Gradle version embedded in the build.

Forwarding the property reveals that Gradle below 8.2.1 cannot configure a
Kotlin DSL build script that applies this plugin, because the plugin is
compiled by the Kotlin compiler embedded in a newer Gradle.  Skip the Kotlin
DSL tests there; the Groovy tests still cover those Gradle versions.

Also refresh the version matrix and fix the test-report artifact path, which
named a source set that does not exist.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Gradle compatibility matrix now includes newer patch releases and documents the Kotlin DSL limitation below Gradle 8.2.1. The Gradle version property is configured independently from the Java toolchain property. Functional test reports use the functional test report directory. Kotlin DSL functional tests define Gradle 8.2.1 as the minimum supported version and skip setup for older versions.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch config-cache-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/gradle.yml:
- Around line 61-65: Add a job-level permissions block to the test-gradle job,
granting only contents: read for its checkout, setup, Gradle, and
artifact-upload steps; leave all other token scopes omitted.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c885008a-17c0-4d9f-9f29-9d499abd23d5

📥 Commits

Reviewing files that changed from the base of the PR and between de659cf and 6fb5897.

📒 Files selected for processing (4)
  • .github/workflows/gradle.yml
  • build.gradle.kts
  • src/functionalTest/kotlin/org/checkerframework/plugin/gradle/Fixtures.kt
  • src/functionalTest/kotlin/org/checkerframework/plugin/gradle/KotlinPluginFunctionalTest.kt

Comment thread .github/workflows/gradle.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants