Skip to content

feat: Impossible to use UUID as param for object construction #706 #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 4, 2021

Conversation

ivanproskuryakov
Copy link
Contributor

Description

The usage of UUID instead of id in routes like http://0.0.0.0:3000/api/products/04879b32-c329-48d7-a652-818794b684f1
Is trying to build JSON object while returning a raw parameter(UUID) provided.

Ref: #703

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [s] tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

The conditions the inside normalizeParamValue now excluding "param" type, keeping UUID strings untouched

@ivanproskuryakov
Copy link
Contributor Author

ivanproskuryakov commented Jul 20, 2021

The PR is a copy of closed #708

@ivanproskuryakov
Copy link
Contributor Author

@fabiob @NoNameProvided @jotamorais hi, could you take a look?

@jotamorais jotamorais merged commit f163c34 into typestack:develop Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants