Skip to content

fix(Interceptors): order of global interceptors #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix(Interceptors): order of global interceptors #543

merged 1 commit into from
Apr 22, 2020

Conversation

ideal123
Copy link
Contributor

@ideal123 ideal123 commented Mar 3, 2020

Interceptor's param { priority: nubmer } is not work

@nolazybits
Copy link
Contributor

nolazybits commented Mar 4, 2020

@NoNameProvided please please please if this fix ordering this will be 👍

@nolazybits
Copy link
Contributor

anyone?

@jotamorais
Copy link
Member

anyone?

Thanks for your PR @ideal123.
@nolazybits, I will test it and integrate it in the following days.

@nolazybits
Copy link
Contributor

@jotamorais have you had the chance to look into it please?

@nolazybits
Copy link
Contributor

Sorry to spam this thread but this is currently bitting me and I would really like to have this merged @jotamorais if you don't mind.

Thanks

@nolazybits
Copy link
Contributor

@jotamorais @NoNameProvided could you please merge this PR?

@jotamorais
Copy link
Member

I will review and merge soon - was tied up with work.

@nolazybits
Copy link
Contributor

... 😞

@nolazybits
Copy link
Contributor

nolazybits commented Apr 19, 2020

Should I fork the repo... sadly it seems most of the typestack family is not getting the love it deserves

@nolazybits
Copy link
Contributor

happy to help btw (MR, etc ...)

@jotamorais jotamorais merged commit e7be722 into typestack:master Apr 22, 2020
@jotamorais
Copy link
Member

@nolazybits, thanks again for the PR and apologies the time it took to merge it - I know for contributors it can be frustrating to invest time and effort and don't see the result of the effort incorporated immediately. As I assume happens with many others, I invest my free time to support this project because I use it on a daily basis and believe in what's it proposes to do.
I'm open to suggestions on how to better support and advance with the project.

@nolazybits
Copy link
Contributor

Hello @jotamorais
Thank you for merging this pr (I am not the owner of the pr btw).
I totally understand and know the deal.
Maybe doing a call for more maintainer of the whole typestack would help.
Thanks again for merging it 👍

@jotamorais
Copy link
Member

Yeah, I'm considering that. I will create an issue calling for help and more maintainers in each of the TypeStack repos and pin them so it has visibility.

@nolazybits
Copy link
Contributor

Hello @jotamorais ,

Just wondering, would it be possible please to release this change in a new routing-controller version?
0.8.1 doesn't have this change
https://github.com/typestack/routing-controllers/blob/0.8.1/src/metadata-builder/MetadataBuilder.ts#L62

Thank you for your work.

@JamesMcFall
Copy link

I don't mean to add to the pressure, but I've been waiting for this quick fix to be applied for nearly 3 months as well. I'm really considering forking the repo just to get this working.

Users of this library will be happy to chip in and help to take some pressure/expectation off.

@jotamorais
Copy link
Member

@nolazybits @JamesMcFall

As I mentioned on the other issue comment, I merged several PRs and published a release candidate minutes ago - Release/tag 0.9.0-alpha.1

I agree with the lack of maintenance of all TypeStack projects and I will create an issue and pin in the repository and also in the README, asking for the help of maintainers, reviewers, testers and also for the community, in general, to help with roadmap, documentation, issues triage, answering questions, etc.

I'm an active user of the projects, that's why I volunteered to help with the project maintenance, but I also have my full-time job and family, which leaves me with only a few hours per week, to contribute with this project.

All the help we can get will be welcomed.

@jotamorais jotamorais added this to the 0.9.x release milestone May 29, 2020
@nolazybits
Copy link
Contributor

looking forward to see this pin / info
You can count me in

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants