-
Notifications
You must be signed in to change notification settings - Fork 402
fix(Interceptors): order of global interceptors #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NoNameProvided please please please if this fix ordering this will be 👍 |
anyone? |
Thanks for your PR @ideal123. |
@jotamorais have you had the chance to look into it please? |
Sorry to spam this thread but this is currently bitting me and I would really like to have this merged @jotamorais if you don't mind. Thanks |
@jotamorais @NoNameProvided could you please merge this PR? |
I will review and merge soon - was tied up with work. |
... 😞 |
Should I fork the repo... sadly it seems most of the typestack family is not getting the love it deserves |
happy to help btw (MR, etc ...) |
@nolazybits, thanks again for the PR and apologies the time it took to merge it - I know for contributors it can be frustrating to invest time and effort and don't see the result of the effort incorporated immediately. As I assume happens with many others, I invest my free time to support this project because I use it on a daily basis and believe in what's it proposes to do. |
Hello @jotamorais |
Yeah, I'm considering that. I will create an issue calling for help and more maintainers in each of the TypeStack repos and pin them so it has visibility. |
Hello @jotamorais , Just wondering, would it be possible please to release this change in a new routing-controller version? Thank you for your work. |
I don't mean to add to the pressure, but I've been waiting for this quick fix to be applied for nearly 3 months as well. I'm really considering forking the repo just to get this working. Users of this library will be happy to chip in and help to take some pressure/expectation off. |
As I mentioned on the other issue comment, I merged several PRs and published a release candidate minutes ago - Release/tag 0.9.0-alpha.1 I agree with the lack of maintenance of all TypeStack projects and I will create an issue and pin in the repository and also in the README, asking for the help of maintainers, reviewers, testers and also for the community, in general, to help with roadmap, documentation, issues triage, answering questions, etc. I'm an active user of the projects, that's why I volunteered to help with the project maintenance, but I also have my full-time job and family, which leaves me with only a few hours per week, to contribute with this project. All the help we can get will be welcomed. |
looking forward to see this pin / info |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Interceptor's param { priority: nubmer } is not work