Fix incorrect handling of rejected promises from Middleware.use() #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLytek
approved these changes
Sep 10, 2018
yazshel
force-pushed
the
koa-middleware-error-handling-fix
branch
from
053975b to
c36d1b2
Compare
|
Stale pull request message |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are a number of issues in
KoaDriver.prototype.prepareMiddlewares()which don't correctly handle rejectedPromises returned fromKoaMiddlewareInterface-style classes.This means a user can't make use of error handling when using an
asyncfunction forKoaMiddlewareInterface.use()implementations. Presently, anythrowin anasyncmiddleware function is not handled (node logs an "uncaught Promise rejection" error), and the route simply returns the default 404 status.The simplest way to fix this was to make the
KoaDrivermiddleware wrapper function into anasync, andawaitthe completion of themiddleware.use()(which works for all use cases ofKoaMiddlewareInterface.use()- ie.async, and non-async in bothPromiseand non-Promise` returning forms.