Skip to content

feat: add decorator name to validation metadata #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2022
Merged

feat: add decorator name to validation metadata #1687

merged 3 commits into from
Dec 2, 2022

Conversation

Clashsoft
Copy link
Contributor

@Clashsoft Clashsoft commented Jul 7, 2022

Description

Added the optional name property to ValidationMetadata which is set from options in registerDecorator.
Previously, the information in options.name was lost - it was not possible to find out which concrete decorators are present in a class.

See #622.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)

    not applicable, there is no new logic, only additional data being passed

  • documentation added or updated

    I added jsdoc comments.
    Otherwise not applicable, the affected part of the code is not documented for end users

  • I have run the project locally and verified that there are no errors

Fixes

references #622

Prim3591
Prim3591 previously approved these changes Jul 28, 2022
@Clashsoft
Copy link
Contributor Author

@Prim3591 thanks for approving, can you approve the workflow run as well please?

@Clashsoft
Copy link
Contributor Author

@Prim3591 Bumping this, I still have an ongoing project that is blocked by this change...

@Prim3591
Copy link

@Prim3591 Bumping this, I still have an ongoing project that is blocked by this change...

Thank you for your enthusiasm but I'm not an admin on this repo, and thus not able to merge it. I've just reviewed it because I need it too, by doing so I was expecting the "real admin" could perform this task quicker :)

@NoNameProvided
Copy link
Member

Can you rebase this please to the latest develop? (Instead of rebasing it's easier to cherry-pick it probably.)

@Clashsoft
Copy link
Contributor Author

Can you rebase this please to the latest develop? (Instead of rebasing it's easier to cherry-pick it probably.)

Done!

@NoNameProvided NoNameProvided changed the title Add name to ValidationMetadata feat: add decorator name to validation metadata Dec 2, 2022
@NoNameProvided NoNameProvided merged commit d6b664a into typestack:develop Dec 2, 2022
@Clashsoft Clashsoft deleted the feat/validator-name branch December 2, 2022 18:00
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants