Skip to content

Generate links for typeshed PR numbers in changelog entries #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2025
Merged

Generate links for typeshed PR numbers in changelog entries #180

merged 2 commits into from
Aug 11, 2025

Conversation

@brianschubert
Copy link
Contributor

@brianschubert brianschubert commented Aug 9, 2025

Closes #178

@srittau
Copy link
Member

srittau commented Aug 11, 2025

This should exclude items where there is text in front of the hash. E.g. foo/bar#123 should not be linked. This might be as easy as adding (^|\W) to the front of the regex.

@brianschubert
Copy link
Contributor Author

brianschubert commented Aug 11, 2025

Right now this only matches numbers that are also surrounded by parentheses (i.e. (#NNNNN), but not #NNNNN). The idea is to only replace the PR number that gets added to the message when merging. I thought about trying to match more general cases, but I wasn't sure what false positives there could be. Happy to tweak if you have any suggestions

@srittau srittau merged commit 856fc1c into typeshed-internal:main Aug 11, 2025
3 checks passed
donbarbos added a commit to donbarbos/stub_uploader that referenced this pull request Nov 21, 2025
@donbarbos
Add links for typeshed PR numbers in old changelog entries
e18272f 
Inspired by typeshed-internal#180
@donbarbos donbarbos mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link PR numbers in changelog entries?

3 participants

@brianschubert @srittau @JelleZijlstra