fix(api_call): Handle invalid server response #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharropoulos
approved these changes
Dec 19, 2025
Contributor
tharropoulos
left a comment
tharropoulos
left a comment
There was a problem hiding this comment.
Just a small change in regards to th ecomment
When server response is invalid json still should attempt to respond with proper error code.
vortextangent
force-pushed
the
master
branch
from
7357057 to
a2609a9
Compare
Contributor
Author
|
@tharropoulos Is it possible to add this to v4.9 release as 4.9.4? or maybe as part of the 4.10RC? What is the process to do something like that? I don't see any other branch except for |
Contributor
|
Tags are cut from the master branch cc: @jasonbosco |
Member
|
We don't backport changes to old versions. So this is now available in v6.0.0-RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
PR Checklist
#52