Skip to content

fix(types): use collection field in UnionSearchResponseRequestParams #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rachit367 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(types): use collection field in UnionSearchResponseRequestParams #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Typesense/Types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@ export interface UnionSearchResponse<T extends DocumentSchema>
type AllRequiredBut<T, K extends keyof T> = Required<Omit<T, K>> & Pick<T, K>;

export interface UnionSearchResponseRequestParams
extends AllRequiredBut<SearchResponseRequestParams, "voice_query"> {
extends Omit<

@tharropoulos tharropoulos May 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the omit, keep it as an optional prop and add collection as optional as well

AllRequiredBut<SearchResponseRequestParams, "voice_query">,
"collection_name"
> {
collection: string;
found: number;
}

Expand Down
Loading