This repository was archived by the owner on Sep 17, 2023. It is now read-only.
feat: add subcommand to lint depenendency versions for consistent values #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCrosson
commented
Apr 30, 2022
| }) | ||
| .take(1) | ||
| .next() | ||
| } |
There was a problem hiding this comment.
Got a q for @ocornoc
Does clone not work here because we need to change types, and clone can only preserve type?
The `lint-dependency-version` subcommand takes a list of dependencies, and for each dependency will test that there is at most one version of that dependency in use throughout the target monorepo. If this condition is violated, the command will exit non-zero exit code. The plan is to use this in CI to enforce monorepo invariants for using only a single version of a given external dependency; for example, `typescript`. Ideally we separate out the library and binary code in this crate, and later we can write multiple binaries that use this library, one of which will invoke this new code and can function as a stand-alone Drone plugin. Thinking about it now, the coupling to Drone is not a goal of this crate but importing the library portion of this codebase from a different crate will be a prerequisite for the plugin.
EricCrosson
force-pushed
the
lint-dependency-version
branch
from
1970678 to
c3810c0
Compare
EricCrosson
commented
Apr 30, 2022
| @@ -59,7 +61,6 @@ pub struct MakeDepend { | |||
|
|
|||
| #[derive(Parser)] | |||
| pub struct Query { | |||
| /// internal-dependencies | |||
There was a problem hiding this comment.
Pretty sure this doesn't appear anywhere in the docstring
EricCrosson
commented
Apr 30, 2022
| } | ||
|
|
||
| fn most_common_dependency_version( | ||
| package_manifests_by_dependency_version: &HashMap<String, Vec<String>>, |
There was a problem hiding this comment.
@ocornoc if I wanted to semantically type String to something narrower like PackageManifestPath or DependencyVersion, what would that look like?
|
Superseded by #156 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lint-dependency-versionsubcommand takes a list of dependencies,and for each dependency will test that there is at most one version
of that dependency in use throughout the target monorepo.
If this condition is violated, the command will exit non-zero exit code.
The plan is to use this in CI to enforce monorepo invariants for using
only a single version of a given external dependency; for example,
typescript.Ideally we separate out the library and binary code in this crate,
and later we can write multiple binaries that use this library, one
of which will invoke this new code and can function as a stand-alone
Drone plugin. Thinking about it now, the coupling to Drone is not a
goal of this crate but importing the library portion of this codebase
from a different crate will be a prerequisite for the plugin.