Skip to content
This repository was archived by the owner on Sep 17, 2023. It is now read-only.

Graysons suggestions #141

Merged
merged 7 commits into from
Apr 11, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove unnecessary type ascriptions
  • Loading branch information
ocornoc committed Apr 11, 2022
commit f6e56da3a5a5662a0ee45af5ddc30f424229dd72
8 changes: 4 additions & 4 deletions src/package_manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ impl PackageManifest {
package_manifest_by_package_name: &HashMap<String, &'a PackageManifest>,
) -> Vec<&'a PackageManifest> {
// Depth-first search all transitive internal dependencies of package
let mut seen_package_names: HashSet<&str> = HashSet::new();
let mut internal_dependencies: HashSet<String> = HashSet::new();
let mut to_visit_package_manifests: VecDeque<&PackageManifest> = VecDeque::new();
let mut seen_package_names = HashSet::new();
let mut internal_dependencies = HashSet::new();
let mut to_visit_package_manifests = VecDeque::new();

to_visit_package_manifests.push_back(self);

Expand All @@ -137,7 +137,7 @@ impl PackageManifest {
.internal_dependencies_iter(package_manifest_by_package_name)
{
internal_dependencies.insert(dependency.contents.name.to_owned());
if !seen_package_names.contains(&dependency.contents.name.as_ref()) {
if !seen_package_names.contains(&dependency.contents.name) {
to_visit_package_manifests.push_back(dependency);
}
}
Expand Down