This repository was archived by the owner on Sep 17, 2023. It is now read-only.
fix(make-depend)!: remove use of force-local #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes hard-coded use of `lerna bootstrap`'s
`--force-local`[^1] command, so that monorepos that don't want to
opt in to this behavior are not forced to.
For projects that wish to include the `--force-local` flag on every
invocation to `lerna bootstrap`, perhaps to prevent dependency
confusion attacks, we recommend specifying this in the lerna
manifest. For example, your lerna.json could look like
```
{
"packages": [
"packages/*"
],
"command": {
"bootstrap": {
"forceLocal": true
}
}
}
```
To prevent the case where a project was expecting `--force-local`
to be applied, but not specifying this in the configuration file,
we consider this a breaking change.
[^1]: https://github.com/lerna/lerna/blob/main/commands/bootstrap/README.md#--force-local
BREAKING CHANGE: do not specify `--force-local` in makefiles generated by `make-depend`
EricCrosson
deleted the
remove-non-default-setting-in-generated-makefile
branch
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes hard-coded use of
lerna bootstrap's--force-local1 command, so that monorepos that don't want toopt in to this behavior are not forced to.
For projects that wish to include the
--force-localflag on everyinvocation to
lerna bootstrap, perhaps to prevent dependencyconfusion attacks, we recommend specifying this in the lerna
manifest. For example, your lerna.json could look like
To prevent the case where a project was expecting
--force-localto be applied, but not specifying this in the configuration file,
we consider this a breaking change.
BREAKING CHANGE: do not specify
--force-localin makefiles generated bymake-dependFootnotes
https://github.com/lerna/lerna/blob/main/commands/bootstrap/README.md#--force-local ↩