This repository was archived by the owner on Sep 17, 2023. It is now read-only.
fix: use pack source instead of hardlink #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitgopatmcl
force-pushed
the
pack-from-relative-dir
branch
from
b21ef00 to
ea63d1c
Compare
bitgopatmcl
force-pushed
the
pack-from-relative-dir
branch
from
ea63d1c to
4383106
Compare
bitgoAaron
approved these changes
Mar 17, 2022
EricCrosson
reviewed
Mar 17, 2022
| .to_str() | ||
| .expect("npm pack filename is not UTF-8 encodable") | ||
| .expect("source package path is not UTF-8 encodable") |
There was a problem hiding this comment.
expect messages start with an uppercase letter in this project, except for npm because npm is a proper noun 😅
Not blocking, can follow-up
EricCrosson
approved these changes
Mar 17, 2022
|
🎉 This PR is included in version 3.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid race conditions from multiple build jobs clobbering the pack file, instead of creating an archive and hardlinking it around, just pack up packages directly to their intended destinations.