Skip to content

ts 3.9 breaking changes 번역 (resolve #72) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2020
Merged

ts 3.9 breaking changes 번역 (resolve #72) #76

merged 8 commits into from
May 19, 2020

Conversation

guyeol
Copy link
Member

@guyeol guyeol commented May 18, 2020

리뷰 부탁드립니다

@guyeol guyeol added the 🚀 번역중 번역을 진행하고 있어요 label May 18, 2020
@guyeol guyeol requested review from bumkeyy, yeonjuan and dvlprsh May 18, 2020 06:18
@guyeol guyeol self-assigned this May 18, 2020
}

interface B {
b: string;
}

interface C {
a?: boolean; // notice this is 'boolean'
a?: boolean; // 'boolean' 인것에 주목
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a?: boolean; // 'boolean' 인것에 주목
a?: boolean; // 'boolean' 인 것에 주목

Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦었지만 고생하셨습니다 😓

Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

guyeol and others added 5 commits May 19, 2020 10:31
Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
Co-authored-by: seoheePark <dvlprsh103@gmail.com>
Co-authored-by: seoheePark <dvlprsh103@gmail.com>
Co-authored-by: seoheePark <dvlprsh103@gmail.com>
@guyeol guyeol merged commit 277e822 into master May 19, 2020
@guyeol guyeol deleted the issue72 branch May 19, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 번역중 번역을 진행하고 있어요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants