Skip to content

About this Handbook 까지 번역 issue#122 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 24, 2020

Conversation

sangminK
Copy link
Contributor

The Handbook 번역에서 About this Handbook 까지 번역했습니다.
번역할 적절한 용어를 찾지 못한 단어는 영문 그대로 표기했습니다.(ex. API surface)
front-end 와 back-end 는 프런트엔드와 백엔드 로 번역해도 괜찮을까요??

의역과 오역 확인해주시면 감사하겠습니다. ^^

@bumkeyy bumkeyy requested review from bumkeyy, dvlprsh and guyeol August 17, 2020 13:29
@bumkeyy
Copy link
Member

bumkeyy commented Aug 18, 2020

The Handbook 번역에서 About this Handbook 까지 번역했습니다.
번역할 적절한 용어를 찾지 못한 단어는 영문 그대로 표기했습니다.(ex. API surface)
front-end 와 back-end 는 프런트엔드와 백엔드 로 번역해도 괜찮을까요??

의역과 오역 확인해주시면 감사하겠습니다. ^^

사소하지만 프론트엔드는 어떤가요? ㅎㅎㅎㅎ
제안입니다.

Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

sangminK and others added 5 commits August 19, 2020 09:44
감사합니다 :)

Co-authored-by: GuyeolJeong <jigu8534@gmail.com>
Co-authored-by: GuyeolJeong <jigu8534@gmail.com>
Co-authored-by: GuyeolJeong <jigu8534@gmail.com>
Co-authored-by: GuyeolJeong <jigu8534@gmail.com>
감사합니다 :)

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
@sangminK sangminK requested review from bumkeyy, guyeol and dvlprsh August 19, 2020 05:06
@sangminK
Copy link
Contributor Author

제가 이것저것 눌러보다가 동기화? 처럼 생긴 버튼을 눌렀는데 멘토님이 동의한게 초기화 되버렸네요...ㅠ

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangminK 번역감사합니당 👍 다소 어색한 문장을 수정해 봤습니다.

감사합니다 :)

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
@guyeol
Copy link
Member

guyeol commented Aug 22, 2020

@sangminK
현재 리뷰 코멘트 resolve 되면 merge 할게요~!

sangminK and others added 2 commits August 24, 2020 10:05
감사합니다.

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
감사합니다 :)

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
@dvlprsh dvlprsh merged commit 0f4a472 into typescript-kr:master Aug 24, 2020
@dvlprsh
Copy link
Member

dvlprsh commented Aug 24, 2020

@all-contributors please add @sangminK for translation

@allcontributors
Copy link
Contributor

@dvlprsh

I've put up a pull request to add @sangminK! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants