-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type-utils): support intersection types in TypeOrValueSpecifier #9633
feat(type-utils): support intersection types in TypeOrValueSpecifier #9633
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4b50da9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v8 #9633 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 401 401
Lines 13637 13639 +2
Branches 3960 3961 +1
=======================================
+ Hits 12003 12005 +2
Misses 1325 1325
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
Changes
specifierNameMatches
to:type.types.some(...)
recursivelySending this to the
v8
branch because it's based on someTypeOrValueSpecifier
changes inv8
. But it doesn't block shipping v8 and isn't a part of the v8 milestone.💖