Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type-utils): support intersection types in TypeOrValueSpecifier #9633

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 24, 2024

PR Checklist

Overview

Changes specifierNameMatches to:

  1. Always check alias names of the types, to support directly matching type aliases
  2. For intersection types, also check type.types.some(...) recursively

Sending this to the v8 branch because it's based on some TypeOrValueSpecifier changes in v8. But it doesn't block shipping v8 and isn't a part of the v8 milestone.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b50da9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a10a9e2048d60008058d85
😎 Deploy Preview https://deploy-preview-9633--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(type-utils): [TypeOrValueSpecifier] support intersection types feat(type-utils): support intersection types in TypeOrValueSpecifier Jul 24, 2024
Copy link

nx-cloud bot commented Jul 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b50da9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (56ef573) to head (4b50da9).
Report is 1 commits behind head on v8.

Additional details and impacted files
@@           Coverage Diff           @@
##               v8    #9633   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         401      401           
  Lines       13637    13639    +2     
  Branches     3960     3961    +1     
=======================================
+ Hits        12003    12005    +2     
  Misses       1325     1325           
  Partials      309      309           
Flag Coverage Δ
unittest 88.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/typeOrValueSpecifiers/specifierNameMatches.ts 100.00% <100.00%> (ø)

@auvred auvred added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 28, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 90432a2 into typescript-eslint:v8 Jul 29, 2024
71 of 72 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants