-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507
feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507
Conversation
…ect-types from v8 to v7
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FYI @JoshuaKGoldberg - I just merged #9363 to v8, so you'll want to update this PR with those changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
64972b7
Aha! The check from #9243 is saving us on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like might need to rerun some test snapshots? Otherwise LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9507 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.01%
==========================================
Files 419 422 +3
Lines 14620 14652 +32
Branches 4279 4287 +8
==========================================
+ Hits 12922 12953 +31
Misses 1374 1374
- Partials 324 325 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
dd965a4
into
typescript-eslint:main
PR Checklist
Overview
Also adds the docs touchup requested by #9503 while I'm in the area.
💖