-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not pass tsconfig canonical file name to typescript API to get program details for config file #9042
fix: do not pass tsconfig canonical file name to typescript API to get program details for config file #9042
Conversation
…am details for config file Without this it generates root files with incorrect casing and results in errors with casing with forceConsistentCasingInFileNames which is true by default in newer typescript versions
Thanks for the PR, @sheetalkamat! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @sheetalkamat! So even without the change on the TS side this should massively help the linked OOM issue right?
That’s right .. this should fix OOM with force consistent file name errors without typescript fix .. not sure if there are more places in which canonical path is passed in to API though .. |
I'm going to go ahead and merge this, thanks again @sheetalkamat |
Woohoo, thanks for this !! |
PR Checklist
Overview
Without this it generates root files with incorrect casing and results in errors with casing with forceConsistentCasingInFileNames which is true by default in newer typescript versions
This came up while i was working on PR microsoft/TypeScript#58398
cc @jakebailey i was able to turn the tsconfig cache into Map and find all places where it needed to be string and was passing canonical file path