Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast-spec): remove deprecated type params #8933

Merged

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Apr 15, 2024

BREAKING CHANGE:
Removes properties from the AST.

PR Checklist

Overview

Remove @deprecated typeParameters properties that were deprecated in #6274

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a8f3699
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665052721dacac0008344181
😎 Deploy Preview https://deploy-preview-8933--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Apr 15, 2024

@abrahamguo abrahamguo changed the title enhancement(ast-spect): remove deprecated type params feat(ast-spec): remove deprecated type params Apr 15, 2024
@abrahamguo abrahamguo changed the base branch from main to v8 April 16, 2024 12:03
@abrahamguo abrahamguo changed the base branch from v8 to main April 16, 2024 12:03
@auvred auvred added the breaking change This change will require a new major version to be released label Apr 16, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(waiting on test failures)

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Apr 22, 2024
@abrahamguo abrahamguo changed the base branch from main to v8 April 25, 2024 11:50
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 25, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙌 Very excited to see most of our @deprecated AST spec properties gone.

Since this touches sensitive code, I'll leave it with 1 approval for another member of @typescript-eslint/triage-team to take a look. I don't trust myself. 🙂

Old timey Smurf cartoon showing a smurf sweeping a floor

eslint.config.mjs Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit ad3ff43 into typescript-eslint:v8 May 24, 2024
60 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Remove AST properties deprecated in v6
3 participants