fix(eslint-plugin): [no-useless-template-literals] detect TemplateLiteral

[waynzh]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-useless-template-literals] doesn't detect constant template literals in interpolations #8545 fixes Bug: [no-useless-template-literals] Nested template literals contain useless one #8584
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Add detect for TemplateLiteral

[typescript-eslint]

Thanks for the PR, @waynzh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	67c097e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e82fb75a2ecb0008efa584
😎 Deploy Preview	https://deploy-preview-8575--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 67c097e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test visitor-keys
• nx test scope-manager
• nx run types:build
• nx test typescript-estree
• nx test utils
• nx test type-utils
• nx test typescript-eslint
• nx run repo-tools:postinstall-script
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test ast-spec
• nx test eslint-plugin-internal
• nx test parser
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx run-many --target=typecheck --parallel
• nx test ast-spec --coverage=false
• nx test scope-manager --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test parser --coverage=false
• nx test repo-tools --coverage=false
• nx run integration-tests:test
• nx test typescript-estree --coverage=false
• nx test visitor-keys --coverage=false
• nx test utils --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-eslint --coverage=false
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (6954a4a) to head (67c097e).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8575      +/-   ##
==========================================
+ Coverage   87.12%   87.17%   +0.04%     
==========================================
  Files         251      251              
  Lines       12268    12275       +7     
  Branches     3868     3872       +4     
==========================================
+ Hits        10689    10701      +12     
+ Misses       1307     1303       -4     
+ Partials      272      271       -1     

Flag	Coverage Δ
unittest	87.17% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...t-plugin/src/rules/no-useless-template-literals.ts	100.00% <100.00%> (ø)

... and 58 files with indirect coverage changes

[auvred]

LGTM! 🚀 Thanks for working on this!

[kirkwaiblinger]

@waynzh Nice work on this!
Unfortunately, I didn't notice this PR until just now, and I worked on a fix myself over the weekend 🤦.

I did one or two things slightly differently, though, so I thought I'd mention them here. Here is the commit for reference: kirkwaiblinger@8bdddbd.

1. I think that this code should flag on nested template literals with a nonzero number of substitution expressions. The fixer code change is straightforward (feel free to copy it):

              } else if (expression.type === AST_NODE_TYPES.TemplateLiteral) {
                // Note that some template literals get handled in the previous branch too.
                // Remove the beginning and trailing backtick characters.
                fixes.push(
                  fixer.removeRange([
                    expression.range[0],
                    expression.range[0] + 1,
                  ]),
                  fixer.removeRange([
                    expression.range[1] - 1,
                    expression.range[1],
                  ]),
                );

   and the test cases pass.
2. (testing only, not a bug) I think this should have a test case to make sure we don't flag on tagged template literals.

   `
      \`not a useless \${String.raw\`nested interpolation \${a}\`}\`;
   `,

[kirkwaiblinger]

consider just returning boolean/omitting the return type since the type guard isn't needed for any subsequent code.

It's suspect to me to change the type guards based on a pure implementation change in one of the functions being called.

[JoshuaKGoldberg]

Yup, what @kirkwaiblinger said!

Looks great otherwise ✨ very clean. Thanks!

[waynzh]

Sorry for the late reply. I'll refactor the code soon.
Thanks for the review and reference! @kirkwaiblinger @JoshuaKGoldberg

[JoshuaKGoldberg]

[Non-Actionable] Oh, right, this reminds me I'd wanted to file a low-priority followup bug about the comments being removed. Thanks 😄 #8609

[JoshuaKGoldberg]

🙌

[kirkwaiblinger]

🚀