Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule-tester): merge provided linterOptions #10131

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Oct 11, 2024

PR Checklist

Overview

When creating the actualConfig, linterOptions is merged instead of overridden.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @SukkaW!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d8ccfd9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67088dfd2409f80008eaf064
😎 Deploy Preview https://deploy-preview-10131--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Oct 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d8ccfd9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@SukkaW SukkaW changed the title fix(rule-tester): merge provided linteOptions fix(rule-tester): merge provided linterOptions Oct 11, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, nicely done. Thanks! 🧼

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 11, 2024
@JoshuaKGoldberg
Copy link
Member

Normally we wait a week for things, but since we're releasing today & this is a dev tooling fix - merging a bit sooner...

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0884b6a into typescript-eslint:main Oct 14, 2024
68 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: allow configure linterOptions.reportUnusedDisableDirectives in @typescript-eslint/rule-tester
2 participants