Skip to content

Added jsx-equals-spacing converter #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2020
Merged

Added jsx-equals-spacing converter #637

merged 3 commits into from
Jul 25, 2020

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Based on eslint-plugin-react, provide the correct converter for this rule.

@KingDarBoja KingDarBoja added the status: waiting for reviewer Waiting for a maintainer to review label Jul 18, 2020
@KingDarBoja KingDarBoja added this to the Version 1.1 milestone Jul 18, 2020
@KingDarBoja KingDarBoja self-assigned this Jul 18, 2020
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 18, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code looks perfect 💯 , just the one test cleanup please!

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Jul 18, 2020
@KingDarBoja KingDarBoja added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Jul 18, 2020
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Jul 25, 2020
@JoshuaKGoldberg JoshuaKGoldberg merged commit 95a5f24 into typescript-eslint:master Jul 25, 2020
@KingDarBoja KingDarBoja deleted the react/jsx-equals-spacing branch July 25, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

@KingDarBoja KingDarBoja

Labels

None yet

Projects

None yet

Milestone

Version 1.1

Development

Successfully merging this pull request may close these issues.

Missing tslint-react rule: jsx-equals-spacing

2 participants

@KingDarBoja @JoshuaKGoldberg