Skip to content

refactor: ban-ts-ignore converter to ban-ts-comment #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2020
Merged

refactor: ban-ts-ignore converter to ban-ts-comment #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/rules/converters/ban-ts-ignore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
import { RuleConverter } from "../converter";

export const BAN_TS_IGNORE_NOTICE =
"The typescript-eslint now bans @ts-<directive> comments from being used";

export const convertBanTsIgnore: RuleConverter = () => {
return {
rules: [
{
ruleName: "@typescript-eslint/ban-ts-ignore",
ruleName: "@typescript-eslint/ban-ts-comment",
notices: [BAN_TS_IGNORE_NOTICE],
},
],
};
Expand Down
5 changes: 3 additions & 2 deletions src/rules/converters/tests/ban-ts-ignore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { convertBanTsIgnore } from "../ban-ts-ignore";
import { convertBanTsIgnore, BAN_TS_IGNORE_NOTICE } from "../ban-ts-ignore";

describe(convertBanTsIgnore, () => {
test("conversion without arguments", () => {
Expand All @@ -9,7 +9,8 @@ describe(convertBanTsIgnore, () => {
expect(result).toEqual({
rules: [
{
ruleName: "@typescript-eslint/ban-ts-ignore",
ruleName: "@typescript-eslint/ban-ts-comment",
notices: [BAN_TS_IGNORE_NOTICE],
},
],
});
Expand Down