Skip to content

[Experimental Feature] Opt in flag convert disable comments #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 27, 2020
Merged

[Experimental Feature] Opt in flag convert disable comments #246

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
29baeee
Set basic replace comment conversion
Oct 20, 2019
e84bb8c
Fix regex pattern and cli command name for convert comments
Oct 20, 2019
dcfce0c
Fix regex pattern condition to match rules without carriage return
Oct 20, 2019
300ebd3
Replace regex and use tslint functions to retrieve tslint comment data
Oct 21, 2019
fae2869
Switching rule handler
Dec 8, 2019
5dbd345
Merge branch 'master' into feature/opt-in-flag-convert-disable-comments
Dec 8, 2019
8cb8c06
Write file after switching rule comments
Dec 9, 2019
67b4d66
Merge branch 'master' into feature/opt-in-flag-convert-disable-comments
KingDarBoja Dec 26, 2019
2830122
Merge branch 'master' into feature/opt-in-flag-convert-disable-comments
KingDarBoja Mar 28, 2020
dd319f8
replace old path to rulesConverter
KingDarBoja Mar 28, 2020
f1bd492
Merge branch 'master' into feature/opt-in-flag-convert-disable-comments
JoshuaKGoldberg Apr 14, 2020
bacf9e8
Working replacements for single line changes
JoshuaKGoldberg Apr 25, 2020
35adb28
4am and it works
JoshuaKGoldberg Apr 25, 2020
63a3876
Revert .prettierrc testing change
JoshuaKGoldberg Apr 25, 2020
0456314
Love that nullish operator
JoshuaKGoldberg Apr 25, 2020
e61a434
Comments WIP
JoshuaKGoldberg Apr 25, 2020
5248447
Seems to be all working and tested now
JoshuaKGoldberg Apr 25, 2020
da1ace3
Merge branch 'master'
JoshuaKGoldberg Apr 25, 2020
425280a
Feature add: logged directive counts as a summary
JoshuaKGoldberg Apr 25, 2020
87e8953
Docs in CLI and README.md
JoshuaKGoldberg Apr 25, 2020
3098453
Merge branch 'master'
JoshuaKGoldberg Apr 26, 2020
fa7fcda
Filled in basic test for separateErrors
JoshuaKGoldberg Apr 26, 2020
2ec5b67
Normalized output per new norms
JoshuaKGoldberg Apr 26, 2020
bf6574f
Merge branch 'master' (and added --comments validation)
JoshuaKGoldberg Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert .prettierrc testing change
  • Loading branch information
@JoshuaKGoldberg
JoshuaKGoldberg committed Apr 25, 2020
commit 63a3876f681d991cee882bafeb62913a9823408f
3 changes: 1 addition & 2 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"arrowParens": "avoid",
"printWidth": 100,
"tabWidth": 4,
"trailingComma": "all"
}
}