Skip to content

Added converter for react-a11y-image-button-has-alt, react-a11y-img-has-alt #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 3, 2021

PR Checklist

Overview

https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md

Since both input TSLint rules go into the same output ESLint rule, I'm putting them into the same PR. Each input TSLint rule has a notice that the output ESLint rule covers more cases.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Jul 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Jul 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft July 3, 2021 21:09
@JoshuaKGoldberg JoshuaKGoldberg changed the title Added converter for react-a11y-img-has-alt Added converter for react-a11y-image-button-has-alt, react-a11y-img-has-alt Jul 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg removed the request for review from KingDarBoja July 3, 2021 21:10
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 3, 2021 21:21
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Jul 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg merged commit ec6b7c3 into main Jul 14, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the react-a11y-img-has-alt branch July 14, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing react-a11y converter: react-a11y-image-button-has-alt Missing react-a11y converter: react-a11y-img-has-alt
1 participant