Skip to content

Missing Merger for @typescript-eslint/naming-conventionΒ #666

Closed
@mKusch

Description

@mKusch

πŸ’₯ Missing Merger

  • tslint-to-eslint-config version: 1.1.0
  • ESLint version: 7.6.0

CLI Output

✨ 111 rules replaced with their ESLint equivalents. ✨

❗ 8 ESLint rules behave differently from their TSLint counterparts ❗
  Check ./tslint-to-eslint-config.log for details.

❌ 2 errors thrown. ❌
  Check ./tslint-to-eslint-config.log for details.

❓ 6 rules are not known by tslint-to-eslint-config to have ESLint equivalents. ❓
  The "@typescript-eslint/tslint/config" section of ./.eslintrc.js configures eslint-plugin-tslint to run them in TSLint within ESLint.
  Check ./tslint-to-eslint-config.log for details.

☠ Prettier plugins are missing from your configuration. ☠
  We highly recommend running tslint-to-eslint-config --prettier to disable formatting ESLint rules.
  See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.

β™» Consider using --comments to replace TSLint comment directives in your source files. β™»

⚑ 8 new packages are required for this ESLint configuration. ⚑
  npm install @typescript-eslint/eslint-plugin @typescript-eslint/eslint-plugin-tslint @typescript-eslint/parser eslint eslint-plugin-import eslint-plugin-jsdoc eslint-plugin-prefer-arrow eslint-plugin-react --save-dev

βœ… All is well! βœ…

File Output

8 ESLint rules behave differently from their TSLint counterparts:
  * no-console:
    - Custom console methods, if they exist, will no longer be allowed.
  * no-invalid-this:
    - Functions in methods will no longer be ignored.
  * @typescript-eslint/no-unused-expressions:
    - The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.
  * prefer-arrow/prefer-arrow-functions:
    - ESLint does not support allowing standalone function declarations.
    - ESLint does not support allowing named functions defined with the function keyword.
  * eqeqeq:
    - Option "smart" allows for comparing two literal values, evaluating the value of typeof and null comparisons.
  * no-underscore-dangle:
    - Leading or trailing underscores (_) on identifiers will now be forbidden.
  * no-redeclare:
    - ESLint does not support check-parameters.
  * import/no-unassigned-import:
    - ESLint's import/no-unassigned-import now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.

Error: multiple output @typescript-eslint/naming-convention ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md. Thanks!

Error: multiple output @typescript-eslint/naming-convention ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md. Thanks!

6 rules are not known by tslint-to-eslint-config to have ESLint equivalents:
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-bind".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-lambda".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-string-ref".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-self-close".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "object-literal-sort-keys".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "prefer-conditional-expression".

Reproduction

  • nothing special, I had to first upgrade tslint to latest version for the tool to work
  • install the migration tool
  • run npx tslint-to-eslint-config
  • NOTE: parameters are ignored completely, if you add e.g. "--prettier" you will still get the CLI output saying it's recommended to use prettier

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions