Skip to content

πŸ™jsdoc-format does not yet have an ESLint equivalent.Β #148

Closed
@frederik-b

Description

@frederik-b

πŸ’₯ Missing Merger

  • tslint-to-eslint-config version: 0.2.5
  • ESLint version: v6.2.2 (not installed but will use this version)

CLI Output

$ npx tslint-to-eslint-config
npx: installed 39 in 5.35s
✨ 73 rules replaced with their ESLint equivalents. ✨
πŸ“’ 1 ESLint rule behaves differently from their TSLint counterparts: πŸ“’
* no-invalid-this:
  - Functions in methods will no longer be ignored.
πŸ’€ 1 error thrown. πŸ’€
Check ./tslint-to-eslint-config.log for details.
πŸ‘€ 21 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. πŸ‘€
βœ… All is well! βœ…

File Output

Error: multiple output some-rule ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md πŸ™jsdoc-format does not yet have an ESLint equivalent.
max-line-length does not yet have an ESLint equivalent.
no-duplicate-imports does not yet have an ESLint equivalent.
no-duplicate-variable does not yet have an ESLint equivalent.
no-implicit-dependencies does not yet have an ESLint equivalent.
no-reference-import does not yet have an ESLint equivalent.
no-shadowed-variable does not yet have an ESLint equivalent.
no-submodule-imports does not yet have an ESLint equivalent.
no-trailing-whitespace does not yet have an ESLint equivalent.
no-unused-expression does not yet have an ESLint equivalent.
one-line does not yet have an ESLint equivalent.
only-arrow-functions does not yet have an ESLint equivalent.
ordered-imports does not yet have an ESLint equivalent.
prefer-conditional-expression does not yet have an ESLint equivalent.
prefer-switch does not yet have an ESLint equivalent.
quotemark does not yet have an ESLint equivalent.
semicolon does not yet have an ESLint equivalent.
space-within-parens does not yet have an ESLint equivalent.
trailing-comma does not yet have an ESLint equivalent.
triple-equals does not yet have an ESLint equivalent.
variable-name does not yet have an ESLint equivalent.

Reproduction

This happened in a private repo to which I cannot give access.
I'm trying to list everything relevant here.

tsconfig.json

{
  "compileOnSave": true,
  "compilerOptions": {
    "alwaysStrict": true,
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["es2017"],
    "module": "commonjs",
    "moduleResolution": "node",
    "newLine": "LF",
    "noFallthroughCasesInSwitch": true,
    "noImplicitAny": true,
    "noImplicitThis": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "outDir": "dist",
    "skipLibCheck": true,
    "sourceMap": true,
    "strictNullChecks": true,
    "target": "es2017"
  },
  "exclude": ["node_modules", "dist", "src/**/tests"]
}

tslint.json

{
  "extends": "tslint-config-sevenval",
  "rules": {
    "array-type": [true, "generic"],
    "arrow-parens": false,
    "curly": [true, "ignore-same-line"],
    "interface-name": [false, "always-prefix"],
    "max-line-length": [true, 120],
    "no-console": [false],
    "no-string-literal": false,
    "no-trailing-whitespace": true,
    "no-unnecessary-type-assertion": [true],
    "object-literal-sort-keys": false,
    "ordered-imports": [true],
    "prefer-object-spread": true,
    "prefer-switch": true,
    "quotemark": [ true, "single", "avoid-escape" ],
    "semicolon": [true, "never"],
    "space-within-parens": [true, 0],
    "trailing-comma": [ true, {"multiline": "always", "singleline": "never"} ],
    "variable-name": [ true, "allow-leading-underscore", "allow-pascal-case", "ban-keywords", "check-format" ]
  }
}

https://github.com/marvinhagemeister/tslint-config-sevenval/blob/master/index.json is the url to the relevant base config which gets extended.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: incorrect converterRule converter with incomplete, incorrect, or invalid rule names and/or argumentsstatus: accepting prsPlease, send in a PR to resolve this! ✨

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions