Skip to content

Add completions: alter role, create/alter/drop policy, comment, analyze, alter function #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rolang
Copy link
Contributor

@rolang rolang commented Feb 8, 2024

Support for completions:

  • ALTER ROLE
  • CREATE POLICY , ALTER POLICY, DROP POLICY
  • COMMENT
  • ANALYZE
  • ALTER FUNCTION

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f99149) 85.54% compared to head (f0f2008) 85.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   85.54%   85.58%   +0.04%     
==========================================
  Files         135      135              
  Lines        2041     2047       +6     
  Branches      239      245       +6     
==========================================
+ Hits         1746     1752       +6     
  Misses        295      295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolang rolang changed the title Add completions: alter role, create/alter/drop policy, comment, analyze Add completions: alter role, create/alter/drop policy, comment, analyze, alter function Feb 8, 2024
@mpilquist
Copy link
Member

Looks good! Mind retargeting the PR to series/0.6 branch? After PR is merged to series/0.6, I'll merge to main as well so we pick up changes in both 0.6 and 1.0.

@rolang rolang changed the base branch from main to series/0.6.x February 10, 2024 05:41
@rolang rolang changed the base branch from series/0.6.x to main February 10, 2024 05:41
@rolang rolang closed this Feb 10, 2024
@rolang rolang deleted the add-completions-role-policy-comment-analyze branch February 10, 2024 06:04
@rolang
Copy link
Contributor Author

rolang commented Feb 10, 2024

Looks good! Mind retargeting the PR to series/0.6 branch? After PR is merged to series/0.6, I'll merge to main as well so we pick up changes in both 0.6 and 1.0.

ok, I tried to re-target it in the same PR, but it got closed after I re-created the branch based on 0.6.x and can't reopen it :D. Created a new PR instead: #1041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants