Fix embarrassing traverse bugs 🙈 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an empty product we have to still wrap it in `pure`. This wasn't caught because case objects are covered by `Const`.
joroKr21
changed the title
joroKr21
commented
Sep 25, 2021
| if (n == 0) x0 | ||
|
|
||
| def prepend(xs: List[Any])(x: Any) = x :: xs | ||
| def fromList(xs: List[Any]) = |
There was a problem hiding this comment.
Or use a Vector - I can't tell which is better 🤷 - it has to be immutable though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3 bugs in
traverse:pure.This wasn't caught because case objects are covered by
Const.iwhen theApplicativeis lazy.Arrayas an accumulator, e.g. when theApplicativeis forList.