Support new Java Distributions #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* *deprecate* `Distribution.OpenJ9` * *add* `Distribution.Semuru` * *add* `Distribution. Microsoft`
armanbilge
reviewed
Jun 24, 2023
|
|
||
| sealed abstract class Distribution(val rendering: String) extends Product with Serializable | ||
|
|
||
| object Distribution { | ||
| case object Temurin extends Distribution("temurin") | ||
| case object Corretto extends Distribution("corretto") | ||
| @deprecated("Migrate to `temurin`or `semeru` instead.", "0.5.0") |
There was a problem hiding this comment.
Isn't OpenJ9 specifically succeeded by Semeru?
It is highly recommended to migrate workflows from adopt and adopt-openj9, to temurin and semeru respectively
I think adopt -> temurin, adopt-openj9 -> semeru.
https://github.com/actions/setup-java#supported-distributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distribution.OpenJ9Distribution.SemuruDistribution. Microsofthttps://github.com/actions/setup-java#supported-distributions
Followup to: #558