Removed default ligatures behaviour #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added those to resources
armanbilge
reviewed
Mar 1, 2023
Comment on lines
+156
to
+157
| val laikaFontPath = "laika/helium/fonts" | ||
| val tlFontPath = "org/typelevel/sbt/site/fonts" |
There was a problem hiding this comment.
Oh laika puts it under helium? I didn't think fonts are helium specific. Meh, we can leave it as is.
There was a problem hiding this comment.
Well, we can't change it anyway right? This is where they are inside the laika jar
There was a problem hiding this comment.
But yeah, I guess they put it there because the fonts are only used as "part of helium"
There was a problem hiding this comment.
Right, I meant whether we should put it under helium too, to be consistent.
There was a problem hiding this comment.
Easy change if you wanted it, but don't think it adds much really
armanbilge
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default font for code to Fira Mono, which doesn't have ligatures and added the
.ttffiles to resources to ensure they can be properly embedding in a generated.pdf