-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics SDK: implement Prometheus exporter #799
Metrics SDK: implement Prometheus exporter #799
Conversation
1a603df
to
d526d43
Compare
...rometheus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusWriter.scala
Outdated
Show resolved
Hide resolved
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusHttpRoutes.scala
Outdated
Show resolved
Hide resolved
I will take a look over the weekend. |
cf10610
to
f024338
Compare
...rometheus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusWriter.scala
Outdated
Show resolved
Hide resolved
I would keep it for the separate PR.
I think it's good enough. |
Excellent work. We can move forward once we decide what to do with the default parameters. |
this is excellent, can't wait to try it, thanks a lot for the work! |
...s/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusMetricExporter.scala
Outdated
Show resolved
Hide resolved
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusHttpRoutes.scala
Outdated
Show resolved
Hide resolved
...s/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusMetricExporter.scala
Outdated
Show resolved
Hide resolved
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusHttpRoutes.scala
Outdated
Show resolved
Hide resolved
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusHttpRoutes.scala
Outdated
Show resolved
Hide resolved
Thanks for the review and feedback. I'll deal with comments in the next few days. |
f024338
to
5066c4c
Compare
@iRevive I made changes according to the comments, and I also realized that ideally attributes for scope/target info should also go through full preparation, escaping and so on, rather than just call |
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusTextRecord.scala
Outdated
Show resolved
Hide resolved
...theus/src/main/scala/org/typelevel/otel4s/sdk/exporter/prometheus/PrometheusTextRecord.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
5066c4c
to
4a3cd95
Compare
4a3cd95
to
554f43d
Compare
@iRevive could we have a release (snapshot is okay) for this? I'd like to try. |
@lenguyenthanh definitely. The snapshot should be available today |
Resolves #751
A number of things to pay attention to:
sdk-exporter-prometheus
.Sum
with delta temporality should be converted to cumulative temporality, but I don't see any OpenTelemetry SDKs doing such a conversion for Prometheus exporter, they usually just exclude everything with delta temporality, which is also done in this PR.