Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk-trace: define meta: InstrumentMeta[F] as val #731

Merged
merged 1 commit into from
Aug 26, 2024
Merged

sdk-trace: define meta: InstrumentMeta[F] as val #731

merged 1 commit into from
Aug 26, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Aug 21, 2024

{instrument}.meta is always used by the macro under the hood: Counter#add, Histogram#record, etc. So, it makes sense to allocate it only once.

Instruments in the oteljava module also define meta as a const variable.

@iRevive iRevive added tracing Improvements to tracing module module:sdk Features and improvements to the sdk module labels Aug 21, 2024
@iRevive iRevive merged commit cc4c8d9 into typelevel:main Aug 26, 2024
10 checks passed
@iRevive iRevive deleted the sdk-trace/reuse-meta branch August 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:sdk Features and improvements to the sdk module tracing Improvements to tracing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iRevive