core-metrics: remove Histogram.Meta in favor of InstrumentMeta
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
force-pushed
the
core-metrics/histogram-meta
branch
from
84f0545
to
d19f864
Compare
iRevive
added
metrics
NthPortal
approved these changes
Aug 26, 2024
iRevive
force-pushed
the
core-metrics/histogram-meta
branch
from
d19f864
to
d99bcc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot recall why it was implemented that way in the very first place.
Histogram.Metawas needed to provide thedef resourceUnit: Resource[F, Unit]. However, we can constructResource.unitanywhere since it doesn't requireApplicative.