New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-trace: make `Backend#end` public #623

Merged

iRevive merged 1 commit into typelevel:main from iRevive:core-trace/backend-public-end

Apr 23, 2024

Contributor

iRevive commented Apr 22, 2024

Closes #204.

A few points:

How many people need to implement their own Backend? It's less relevant since we have an sdk-trace module.
Initially, Span had no public end API. The lifecycle has been managed automatically. So the Backend#end was private to prevent a user from ending a span by calling backend.end. Currently, Span has a public end API, so I don't think we should keep Backend#end private too.

iRevive requested a review from NthPortal

April 22, 2024 06:15


          core-trace: make Backend#end public

3a06d12

iRevive force-pushed the core-trace/backend-public-end branch from 0e07859 to 3a06d12 Compare

April 22, 2024 06:20

iRevive added the tracing label

NthPortal approved these changes

View reviewed changes

iRevive merged commit c0057ea into typelevel:main

10 checks passed

iRevive deleted the core-trace/backend-public-end branch

April 23, 2024 14:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tracing