Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk-common: add ComponentRegistry #622

Merged
merged 1 commit into from
Apr 22, 2024
Merged

sdk-common: add ComponentRegistry #622

merged 1 commit into from
Apr 22, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Apr 21, 2024 •
edited
Loading

Reference Link
Spec https://opentelemetry.io/docs/specs/otel/trace/api/#get-a-tracer
Java implementation ComponentRegistry.java

The use cases:

  1. we need ComponentRegistry to keep Meters unique
  2. we need access to all instruments registered within SDK - see https://github.com/iRevive/otel4s/pull/4/files#diff-69173f42493b6c306e7ea1f016463b66dee4de03bd3e1c32951d23e9b8a2848dR268-R279

@iRevive iRevive added the module:sdk Features and improvements to the sdk module label Apr 21, 2024
@iRevive iRevive merged commit f78a10b into typelevel:main Apr 22, 2024
10 checks passed
@iRevive iRevive deleted the sdk-common/component-registry branch April 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:sdk Features and improvements to the sdk module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iRevive