Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttributeConverters #544

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add AttributeConverters #544

merged 1 commit into from
Mar 12, 2024

Conversation

NthPortal
Copy link
Contributor

Add AttributeConverters for converting between Java and Scala AttributeKeys and Attributes.

@NthPortal NthPortal added the module:oteljava Features and improvements to the oteljava module label Mar 11, 2024
@NthPortal NthPortal requested a review from iRevive March 11, 2024 20:46
@NthPortal
Add AttributeConverters
d9b8924 
Add `AttributeConverters` for converting between Java and Scala
`AttributeKey`s and `Attributes`.
iRevive
iRevive approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@iRevive iRevive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement, thank you!

@NthPortal NthPortal merged commit 028844e into typelevel:main Mar 12, 2024
10 checks passed
@NthPortal NthPortal deleted the attribute-converters/PR branch March 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRevive iRevive iRevive approved these changes

Assignees
No one assigned
Labels
module:oteljava Features and improvements to the oteljava module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NthPortal @iRevive