Replace otel4s-testkit with otel4s-oteljava-testkit
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
force-pushed
the
testkit/metrics
branch
from
03546bb
to
24b8aa7
Compare
iRevive
force-pushed
the
testkit/metrics
branch
from
24b8aa7
to
4dac39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started the testkit module the Scala SDK wasn't in plans. From what I see, it's a relatively complex task to build a generic testkit module that would work fine with both implementations.
Instead, we can provide a separate testkit for every implementation while leveraging the unique features of each of them.
Scope for this PR:
testkit-*into theoteljava-*-testkitcorresponding modulestestkitmodulesA brief search over GitHub shows no one is using the testkit module. So I don't think we should write a scalafix migration.