Skip to content

Add methods to override Span.Options on the span created by the client middleware#64

Merged
mpilquist merged 1 commit intotypelevel:mainfrom
Dwolla:span-options
Oct 2, 2024
Merged

Add methods to override Span.Options on the span created by the client middleware#64
mpilquist merged 1 commit intotypelevel:mainfrom
Dwolla:span-options

Conversation

@bpholt
Copy link
Member

@bpholt bpholt commented Sep 6, 2024

This would allow callers to set the Span Creation Policy, etc., on the span created by the middleware.

…t middleware

This would allow callers to set the Span Creation Policy, etc., on the
span created by the middleware.
@bpholt
Copy link
Member Author

bpholt commented Oct 1, 2024

I can't remember why I marked this as a Draft PR, so I'm going to mark it ready for review and see what feedback I get. 😅

@bpholt bpholt marked this pull request as ready for review October 1, 2024 18:42
@mpilquist mpilquist merged commit 7384a70 into typelevel:main Oct 2, 2024
@bpholt bpholt deleted the span-options branch January 15, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants