Modularised and added Oracle and SQL Server backends #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Split sql module into sql-core and sql-pg, the latter containing Postgres specfics shared by doobie-pg and skunk. + Split off doobie-core from doobie-pg removing all Postgres specfics from the former. + Factored out all Postgres specifics from SqlMapping. + Reduced the use of lateral subqueries to a minimum. + Simplified SqlSelect nesting logic. + Avoid nested conditions being captured by predicate subqueries. + SkunkMapping now instantiated with a Session rather than a session Resource to avoid resource lifecycle on every query. + Replaced whale-tail with call outs to docker-compose allowing container to be shared by all suites across multiple test runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlmodule intosql-coreandsql-pg, the latter containing Postgres specfics shared bydoobie-pgandskunk.doobie-corefromdoobie-pgremoving all Postgres specfics from the former.SqlMapping.SqlSelectnesting logic.SkunkMappingnow instantiated with aSessionrather than a sessionResourceto avoid resource lifecycle on every query.whale-tailwith call outs todocker-composeallowing container to be shared by all suites across multiple test runs.Running tests (eg.
rootJVM/test) will automatically spin up the relevant containers, which will stay up and can be reused across multiple tests runs, significantly speeding up the test cycle. I recommend runningallUpinitially, to pull images and initialise databases, before running tests the first time. Note that Oracle in particular takes quite a long time to initialise, so expectallUpto take several minutes to complete the first time around.There have been some changes in compilation of queries for Postgres, primarily a reduction in the usage of lateral subqueries (partly to simplify the implementation for SQL Server, which has a subtly different mechanism for achieving similar effects). These changes should preserve expected results, and reports of any changes in behaviour, including performance regressions, would be very much appreciated.