-
Notifications
You must be signed in to change notification settings - Fork 619
Unify TCP and UnixSocket APIs #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpilquist
wants to merge
48
commits into
main
Choose a base branch
from
topic/net2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3560
This PR revamps
fs2.io.net
in a number of significant ways:connect
for clients andbind
for servers, both taking the newcom.comcast.ip4s.GenSocketAddress
type, which is a supertype ofSocketAddress[Host]
andUnixSocketAddress
SocketGroup
- there has never really been a great reason to manage explicit thread pools / async socket groups & the API was JVM only. With the new polling system, there's even less of a reason to ever use the explicitly managed socket groups.UnixSockets
as there's no utility provided that's not also provided byNetwork
nowclient
,server
,serverResource
in favor ofconnect
,bindAndAccept
,bind
ServerSocket
, which provides the bound address of the server socket, access to options, and a stream of client sockets.SocketInfo
as a supertype ofSocket
andServerSocket
.address: GenSocketAddress
onSocketInfo
andpeerAddress: GenSocketAddress
onSocket
, replacinglocalAddress
andremoteAddress
(each of typeF[SocketAddress[IpAddress]]
.isOpen
onSocket
which is a vestige from when there was aclose
method.