Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SemigroupK instance for Validated + tests #998

Merged

Conversation

aaronlevin
Copy link
Contributor

No description provided.

@aaronlevin
Copy link
Contributor Author

Similar to my other PR on adding a SemigroupK instance for Xor. The instance requires only that the failure type has a Semigroup constraint.

@ceedubs
Copy link
Contributor

ceedubs commented Apr 25, 2016

Looks great. Thanks @aaronlevin!

👍, but we should get the build issues figured out before we merge so we don't throw more variables into the mix.

@ceedubs
Copy link
Contributor

ceedubs commented Apr 25, 2016

It occurs to me that it might also be handy to create a combineK (or perhaps there's a better name when speaking specifically about Validated) method on Validated directly and have the SemigroupK instance simply delegate to it. If we do this we should probably have a scaladoc comment describing how its behavior is a little different than orElse and combine (which wouldn't be a bad comment to have anyway). I'm not saying that you need to feel obligated to do all of this in your PR - just jotting this down before I forget.

@aaronlevin
Copy link
Contributor Author

@ceedubs since we're waiting for the build stuff to get fixed, I'm happy to update this PR tonight (EU time) with your suggestion :)

@ceedubs
Copy link
Contributor

ceedubs commented Apr 25, 2016

Closing and reopening to pick up build fixes.

@ceedubs ceedubs closed this Apr 25, 2016
@ceedubs ceedubs reopened this Apr 25, 2016
@ceedubs
Copy link
Contributor

ceedubs commented Apr 26, 2016

👍

At some point I think it would be good for us to follow up on this comment. I'm happy for that to be a separate effort though.

@aaronlevin
Copy link
Contributor Author

@ceedubs i think it's a good idea, but i can submit another PR with that change. is cats 0.5 about to be released? it'd be nice to get this in there! :)

@ceedubs
Copy link
Contributor

ceedubs commented Apr 26, 2016

@aaronlevin it is and it would be :). We have a convention of waiting for two 👍s before merging, so that's all we are waiting on for this PR as far as I'm concerned.

@adelbertc
Copy link
Contributor

👍

@adelbertc adelbertc merged commit dd10d51 into typelevel:master Apr 26, 2016
@stew stew removed the in progress label Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants