Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -P:scalajs:mapSourceURI option #916

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Mar 4, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 88.78%

Merging #916 into master will not affect coverage as of fe093f8

@@            master    #916   diff @@
======================================
  Files          178     178       
  Stmts         2122    2122       
  Branches        42      42       
  Methods          0       0       
======================================
  Hit           1884    1884       
  Partial          0       0       
  Missed         238     238       

Review entire Coverage Diff as of fe093f8

Powered by Codecov. Updated on successful CI builds.

@milessabin
Copy link
Member

Does this change the release tag name?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Mar 7, 2016

Does this change the release tag name?

No, this is sbt-release plugin's default TaskKey[String] value.

https://github.com/sbt/sbt-release/blob/v1.0.3/src/main/scala/ReleasePlugin.scala#L194

@milessabin
Copy link
Member

Is there any way of using the release plugin's default value without duplicating the definition here?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Mar 7, 2016

releaseTagName is Task but scalacOptions is Setting, Setting can not depends on Task.

@milessabin
Copy link
Member

Gotcha.

@milessabin
Copy link
Member

👍

@non
Copy link
Contributor

non commented Mar 7, 2016

Thanks! 👍

non added a commit that referenced this pull request Mar 7, 2016
@non non merged commit ae7b531 into typelevel:master Mar 7, 2016
@xuwei-k xuwei-k deleted the scalajs-mapSourceURI-option branch March 7, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants